Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl builtin template system package #1195

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Apr 7, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #313

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/runtime/Cargo.toml
  • kclvm/Cargo.lock
  • kclvm/runtime/src/_kclvm.bc
  • kclvm/runtime/src/lib.rs
  • kclvm/runtime/src/template/mod.rs
  • kclvm/sema/src/builtin/system_module.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Unit test

  • kclvm/api/src/service/service_impl.rs
  • kclvm/loader/src/snapshots/**
  • kclvm/tools/src/LSP/src/completion.rs

Grammar test

  • test/grammar/builtins/template/execute_0/main.k
  • test/grammar/builtins/template/execute_1/main.k
  • test/grammar/builtins/template/html_escape_0/main.k

Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy added this to the v0.9.0 Release milestone Apr 7, 2024
@Peefy Peefy added stdlib Issues or PRs related to kcl standard libraries enhancement New feature or request labels Apr 7, 2024
@Peefy Peefy merged commit 9a30ca6 into kcl-lang:main Apr 7, 2024
5 of 8 checks passed
@Peefy Peefy deleted the builtin_template_package branch April 7, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stdlib Issues or PRs related to kcl standard libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant