Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add loader API with state #1202

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Apr 8, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • feat: add loader API with state

2. What is the scope of this PR (e.g. component or file name):

  • .gitignore
  • kclvm/api/src/service/service_impl.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@Peefy Peefy added the api Issues or PRs related to kcl rust native APIs and multi-lang APIs label Apr 8, 2024
@Peefy Peefy added this to the v0.9.0 Release milestone Apr 8, 2024
Signed-off-by: Peefy <xpf6677@163.com>
@Peefy Peefy force-pushed the feat-loader-api-with-state branch from 7bbfab8 to a471297 Compare April 8, 2024 16:12
@coveralls
Copy link
Collaborator

coveralls commented Apr 8, 2024

Pull Request Test Coverage Report for Build 8603334429

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 24 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 71.776%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/api/src/service/service_impl.rs 0 24 0.0%
Totals Coverage Status
Change from base Build 8602055048: -0.01%
Covered Lines: 48014
Relevant Lines: 66894

💛 - Coveralls

@Peefy Peefy merged commit f112a49 into kcl-lang:main Apr 8, 2024
8 checks passed
@Peefy Peefy deleted the feat-loader-api-with-state branch April 8, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issues or PRs related to kcl rust native APIs and multi-lang APIs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants