Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: overridefile supports other types except schema #1208

Merged
merged 6 commits into from
Apr 10, 2024

Conversation

zong-zhe
Copy link
Contributor

@zong-zhe zong-zhe commented Apr 9, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix #1190

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@zong-zhe zong-zhe added the api Issues or PRs related to kcl rust native APIs and multi-lang APIs label Apr 9, 2024
@zong-zhe zong-zhe added this to the v0.9.0 Release milestone Apr 9, 2024
@zong-zhe zong-zhe requested a review from Peefy April 9, 2024 11:42
@zong-zhe zong-zhe self-assigned this Apr 9, 2024
kclvm/query/src/override.rs Outdated Show resolved Hide resolved
kclvm/query/src/override.rs Outdated Show resolved Hide resolved
kclvm/query/src/override.rs Outdated Show resolved Hide resolved
kclvm/query/src/override.rs Outdated Show resolved Hide resolved
kclvm/query/src/override.rs Outdated Show resolved Hide resolved
@coveralls
Copy link
Collaborator

coveralls commented Apr 9, 2024

Pull Request Test Coverage Report for Build 8630100274

Details

  • 137 of 146 (93.84%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.06%) to 71.26%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/query/src/tests.rs 33 34 97.06%
kclvm/query/src/override.rs 78 86 90.7%
Files with Coverage Reduction New Missed Lines %
kclvm/tools/src/LSP/src/state.rs 1 86.15%
Totals Coverage Status
Change from base Build 8627816207: 0.06%
Covered Lines: 47058
Relevant Lines: 66037

💛 - Coveralls

kclvm/query/src/override.rs Show resolved Hide resolved
kclvm/query/src/override.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
@Peefy Peefy merged commit e3113fc into kcl-lang:main Apr 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issues or PRs related to kcl rust native APIs and multi-lang APIs
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Enhancement][API] Support for normal variable and list variable override for OverrideFile API
3 participants