Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: doc string parse to prevent the regex calling and remove the prec2 deps #1219

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Apr 15, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • refactor: doc string parse to prevent the regex calling

  • Removed the regex library prec2, as it requires c99 compilation in some old gcc environments (such as centos7)

  • Removed one clone deep copy and directly used the strip function to remove the first quotation mark

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/sema/Cargo.toml
  • kclvm/sema/src/resolver/doc.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • kclvm/sema/src/resolver/doc.rs

Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy added the semantic Issues or PRs related to kcl semantic and checker label Apr 15, 2024
@Peefy Peefy added this to the v0.9.0 Release milestone Apr 15, 2024
@Peefy Peefy requested a review from He1pa April 15, 2024 03:25
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy changed the title refactor: doc string parse to prevent the regex calling refactor: doc string parse to prevent the regex calling and remove the prec2 deps Apr 15, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8682810265

Details

  • 18 of 23 (78.26%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 73.342%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/sema/src/resolver/doc.rs 18 23 78.26%
Files with Coverage Reduction New Missed Lines %
kclvm/sema/src/core/symbol.rs 3 46.54%
Totals Coverage Status
Change from base Build 8660589058: 0.01%
Covered Lines: 48994
Relevant Lines: 66802

💛 - Coveralls

@Peefy Peefy merged commit bc61341 into kcl-lang:main Apr 15, 2024
7 of 8 checks passed
@Peefy Peefy deleted the refactor-doc-str-parse branch April 15, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semantic Issues or PRs related to kcl semantic and checker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants