Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add build lock for common package cache path #1223

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Apr 17, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix #1222

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/runner/src/lib.rs
  • kclvm/runner/src/tests.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: peefy <xpf6677@163.com>
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8715588118

Details

  • 17 of 35 (48.57%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+21.5%) to 73.305%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/runner/src/lib.rs 17 35 48.57%
Totals Coverage Status
Change from base Build 8701201640: 21.5%
Covered Lines: 48986
Relevant Lines: 66825

💛 - Coveralls

@Peefy Peefy merged commit 0062d5a into kcl-lang:main Apr 17, 2024
7 of 8 checks passed
@Peefy Peefy deleted the add-build-lock-for-common-pkg-cache-path branch April 17, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] KCL unable to run intermittently when KCL_CACHE_PATH set to /tmp
2 participants