Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: schema string attribute contains dot #1228

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Apr 18, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix #1227

fix: schema string attribute contains dot

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/ast/src/ast.rs
  • kclvm/sema/src/pre_process/identifier.rs
  • kclvm/sema/src/resolver/node.rs
  • kclvm/ast_pretty/src/node.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • test/grammar/schema/string_attr/simple_0/main.k
  • test/grammar/schema/string_attr/simple_1/main.k

Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy added the bug Something isn't working label Apr 18, 2024
Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy force-pushed the fix-schema-str-attr-contains-dot branch from 9922308 to 7edf7a9 Compare April 18, 2024 09:52
@coveralls
Copy link
Collaborator

coveralls commented Apr 18, 2024

Pull Request Test Coverage Report for Build 8735903672

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 10 of 10 (100.0%) changed or added relevant lines in 4 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.001%) to 73.327%

Files with Coverage Reduction New Missed Lines %
kclvm/ast_pretty/src/node.rs 1 95.17%
kclvm/ast/src/ast.rs 2 83.42%
Totals Coverage Status
Change from base Build 8722915519: -0.001%
Covered Lines: 49005
Relevant Lines: 66831

💛 - Coveralls

@Peefy Peefy merged commit 26b1b17 into kcl-lang:main Apr 18, 2024
7 of 8 checks passed
@Peefy Peefy deleted the fix-schema-str-attr-contains-dot branch April 18, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Invalid schema string attribute contains dot
2 participants