Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(github action): modify rust toolchain version. #131

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Jul 29, 2022

Rust unstable nightly version causes github action to fail. Fixed it to a stable version.

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

.github/workflows/github-action.yaml

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

Rust unstable nightly version causes github action to fail. Fixed it to a stable version.

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@He1pa He1pa added bug Something isn't working fix test labels Jul 29, 2022
@He1pa He1pa added this to the v0.4.3 Release milestone Jul 29, 2022
@He1pa He1pa self-assigned this Jul 29, 2022
Rust unstable nightly version causes github action to fail. Fixed it to a stable version.
@He1pa He1pa force-pushed the fix_rust_toochain_ver_in_github_action branch from 04a14fc to 741dc97 Compare July 29, 2022 03:43
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 2758196413

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 59.356%

Totals Coverage Status
Change from base Build 2743999583: 0.007%
Covered Lines: 22248
Relevant Lines: 37482

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chai2010 chai2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@He1pa He1pa merged commit 5bc87cf into kcl-lang:main Jul 29, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working fix test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: github action failed
4 participants