Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: override_file will insert a new variable if the variable is not exist #1238

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

zong-zhe
Copy link
Contributor

@zong-zhe zong-zhe commented Apr 22, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

… exist

Signed-off-by: zongz <zongzhe1024@163.com>
@zong-zhe zong-zhe added the enhancement New feature or request label Apr 22, 2024
@zong-zhe zong-zhe added this to the v0.9.0 Release milestone Apr 22, 2024
@zong-zhe zong-zhe requested a review from Peefy April 22, 2024 12:05
@zong-zhe zong-zhe self-assigned this Apr 22, 2024
@Peefy Peefy changed the title feat: override_file will insert a new variable if the variable is not… feat: override_file will insert a new variable if the variable is not exist Apr 22, 2024
kclvm/query/src/override.rs Outdated Show resolved Hide resolved
Signed-off-by: zongz <zongzhe1024@163.com>
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 44947b1 into kcl-lang:main Apr 22, 2024
7 of 8 checks passed
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8783959215

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 83 of 84 (98.81%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.03%) to 71.432%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/query/src/override.rs 38 39 97.44%
Files with Coverage Reduction New Missed Lines %
kclvm/tools/src/LSP/src/request.rs 1 72.02%
kclvm/tools/src/LSP/src/state.rs 1 86.15%
Totals Coverage Status
Change from base Build 8763607955: 0.03%
Covered Lines: 52709
Relevant Lines: 73789

💛 - Coveralls

@zong-zhe zong-zhe deleted the feat-override-file branch June 12, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants