Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Release for Alpine linux #1242

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

shruti2522
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix #1240

2. What is the scope of this PR (e.g. component or file name):

kcl-lang/kcl/scripts/docker

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

Added Dockerfile and Makefile for alpine linux

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>
@Peefy
Copy link
Contributor

Peefy commented Apr 23, 2024

Good Job! LGTM!

@shruti2522 shruti2522 changed the title feat:added kcl-builder-alpine [Enhancement] Release for Alpine linux Apr 23, 2024
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 5871078 into kcl-lang:main Apr 23, 2024
5 of 8 checks passed
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8801204409

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 71.433%

Totals Coverage Status
Change from base Build 8800554216: -0.002%
Covered Lines: 52710
Relevant Lines: 73789

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Release in Alpine and fedora Linux Image
3 participants