Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix lsp e2e test occasionally failed in CI. #1254

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Apr 29, 2024

Add a 50ms delay to ensure write locking during compilation

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

kclvm/tools/src/LSP/src/tests.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

fix test

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

…g compilation

Signed-off-by: he1pa <18012015693@163.com>
@coveralls
Copy link
Collaborator

coveralls commented Apr 29, 2024

Pull Request Test Coverage Report for Build 8890235707

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 17 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.02%) to 71.439%

Files with Coverage Reduction New Missed Lines %
kclvm/tools/src/LSP/src/request.rs 2 71.43%
kclvm/tools/src/LSP/src/dispatcher.rs 7 63.86%
kclvm/tools/src/LSP/src/state.rs 8 83.46%
Totals Coverage Status
Change from base Build 8884901897: -0.02%
Covered Lines: 52747
Relevant Lines: 73835

💛 - Coveralls

Signed-off-by: he1pa <18012015693@163.com>
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit a1bc5a2 into kcl-lang:main Apr 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants