Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kcl argocd zombie workaround #1264

Merged
merged 3 commits into from
May 1, 2024

Conversation

metacoma
Copy link
Contributor

@metacoma metacoma commented May 1, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Fix: kcl-lang/kcl-lang.io#350

2. What is the scope of this PR (e.g. component or file name):

Add new docker image for kcl-cmp argocd plugin with tini util.

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

The steps to test are described here kcl-lang/kcl-lang.io#350

@coveralls
Copy link
Collaborator

coveralls commented May 1, 2024

Pull Request Test Coverage Report for Build 8903770146

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.44%

Totals Coverage Status
Change from base Build 8902980954: 0.0%
Covered Lines: 52748
Relevant Lines: 73835

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 904f74d into kcl-lang:main May 1, 2024
7 of 8 checks passed
JeevaRamanathan pushed a commit to JeevaRamanathan/kcl that referenced this pull request May 7, 2024
* Bump ubuntu base image to 22.04 version

Fix url for python release archive
Fix package name for python3 development files

Fixes kcl-lang#1234

* Add docker image for kcl-cmp plugin with tini utility

Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Zombie (<defunct>) processes within the kcl argocd pod plugin
3 participants