Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enhance the schema expr type check and impl the schema factory using the dynamic type #1269

Merged
merged 1 commit into from
May 4, 2024
Merged

feat: enhance the schema expr type check and impl the schema factory using the dynamic type #1269

merged 1 commit into from
May 4, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented May 2, 2024 •
edited

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix #1265

feat: enhance the schema expr type check and impl the schema factory using the runtime dynamic type string.

test cases are

  • test/grammar/schema/factory/test_0/main.k
  • test/grammar/schema/factory/test_1/main.k
  • test/grammar/schema/factory/test_2/main.k

@Peefy Peefy added enhancement New feature or request runtime Issues or PRs related to kcl runtime including value and value opertions resolver labels May 2, 2024
@Peefy Peefy added this to the v0.9.0 Release milestone May 2, 2024
@Peefy Peefy mentioned this pull request May 2, 2024
Closed
@Peefy Peefy force-pushed the enhance-schema-any-ty-check branch 2 times, most recently from 5ec3ccb to 73d79ef Compare May 3, 2024 20:00
@Peefy
feat: enhance the schema expr type check and impl the schema factory …
9f55a67 
…using the dynamic type

Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy force-pushed the enhance-schema-any-ty-check branch from 73d79ef to 9f55a67 Compare May 4, 2024 16:42
@Peefy Peefy merged commit f067672 into kcl-lang:main May 4, 2024
6 of 8 checks passed
JeevaRamanathan pushed a commit to JeevaRamanathan/kcl that referenced this pull request May 7, 2024
@Peefy @JeevaRamanathan
feat: enhance the schema expr type check and impl the schema factory …
964a23d 
…using the dynamic type (kcl-lang#1269)

Signed-off-by: peefy <xpf6677@163.com>
Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request resolver runtime Issues or PRs related to kcl runtime including value and value opertions
Projects
None yet
Milestone
v0.9.0 Release
Development

Successfully merging this pull request may close these issues.

[feature] Support for type arguments for convenient factory functions
1 participant
@Peefy