Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add file folder cp #1281

Merged
merged 1 commit into from
May 6, 2024
Merged

feat: add file folder cp #1281

merged 1 commit into from
May 6, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented May 6, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • feat: add file folder cp

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/runtime/src/file/mod.rs
  • kclvm/runtime/src/file/utils.rs
  • kclvm/sema/src/builtin/system_module.rs

Signed-off-by: peefy <xpf6677@163.com>
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit b363e68 into kcl-lang:main May 6, 2024
9 of 10 checks passed
@Peefy Peefy deleted the feat-file-cp-folder branch May 6, 2024 08:46
@coveralls
Copy link
Collaborator

coveralls commented May 6, 2024

Pull Request Test Coverage Report for Build 8966150691

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 4 of 36 (11.11%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 71.363%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/runtime/src/file/mod.rs 0 16 0.0%
kclvm/runtime/src/file/utils.rs 0 16 0.0%
Totals Coverage Status
Change from base Build 8965467265: -0.03%
Covered Lines: 52879
Relevant Lines: 74099

💛 - Coveralls

JeevaRamanathan pushed a commit to JeevaRamanathan/kcl that referenced this pull request May 7, 2024
Signed-off-by: peefy <xpf6677@163.com>
Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants