Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add operation for variable in ListVariables #1282

Merged
merged 2 commits into from
May 6, 2024

Conversation

zong-zhe
Copy link
Contributor

@zong-zhe zong-zhe commented May 6, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: zongz <zongzhe1024@163.com>
@zong-zhe zong-zhe added the api Issues or PRs related to kcl rust native APIs and multi-lang APIs label May 6, 2024
@zong-zhe zong-zhe added this to the v0.9.0 Release milestone May 6, 2024
@zong-zhe zong-zhe requested a review from Peefy May 6, 2024 08:58
@zong-zhe zong-zhe self-assigned this May 6, 2024
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: zongz <zongzhe1024@163.com>
@coveralls
Copy link
Collaborator

coveralls commented May 6, 2024

Pull Request Test Coverage Report for Build 8968362814

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 87 of 92 (94.57%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 71.376%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/query/src/selector.rs 32 37 86.49%
Files with Coverage Reduction New Missed Lines %
kclvm/query/src/selector.rs 1 82.18%
Totals Coverage Status
Change from base Build 8966458000: 0.01%
Covered Lines: 52924
Relevant Lines: 74148

💛 - Coveralls

@Peefy Peefy merged commit 58ff118 into kcl-lang:main May 6, 2024
9 of 10 checks passed
JeevaRamanathan pushed a commit to JeevaRamanathan/kcl that referenced this pull request May 7, 2024
* feat: add operation for variable in ListVariables

Signed-off-by: zongz <zongzhe1024@163.com>

* fix: fix test case

Signed-off-by: zongz <zongzhe1024@163.com>

---------

Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
@zong-zhe zong-zhe deleted the list-variable-op branch June 12, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issues or PRs related to kcl rust native APIs and multi-lang APIs
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants