Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type cast when exists external package #1297

Merged
merged 1 commit into from
May 8, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented May 8, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • fix: type cast when exists external package

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/evaluator/src/ty.rs
  • kclvm/runtime/src/value/val_type.rs

Signed-off-by: peefy <xpf6677@163.com>
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

coveralls commented May 8, 2024

Pull Request Test Coverage Report for Build 8998806625

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 5 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.002%) to 71.142%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/evaluator/src/ty.rs 0 1 0.0%
kclvm/runtime/src/value/val_type.rs 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
kclvm/runtime/src/value/val_type.rs 1 60.71%
Totals Coverage Status
Change from base Build 8994730680: -0.002%
Covered Lines: 52981
Relevant Lines: 74472

💛 - Coveralls

@Peefy Peefy merged commit f49db68 into kcl-lang:main May 8, 2024
10 checks passed
@Peefy Peefy deleted the fix-type-cast-external-pkg branch May 8, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants