Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lsp hover docs #1313

Merged
merged 1 commit into from
May 15, 2024
Merged

fix: lsp hover docs #1313

merged 1 commit into from
May 15, 2024

Conversation

shruti2522
Copy link
Contributor

@shruti2522 shruti2522 commented May 14, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

kcl/kclvm/sema/src/ty/mod.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

"schema Data1[n: str](Data)" was being misinterpreted as markdown "schema Data1n: str".

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@shruti2522
Copy link
Contributor Author

current hover:
Screenshot from 2024-05-15 01-58-21

@shruti2522 shruti2522 force-pushed the lsp-fix-hover branch 2 times, most recently from d736c3e to bef21e2 Compare May 14, 2024 21:06
Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

corrected formatting

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

added conditional checks

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

corrected formatting

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

corrected tests

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

escape markdown

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

reverted changes

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

format check

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

fix: lsp hover docs

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

added conditional checks

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

corrected formatting

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

fix: lsp hover docs

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

updated completion test

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>
@coveralls
Copy link
Collaborator

coveralls commented May 14, 2024

Pull Request Test Coverage Report for Build 9086404385

Details

  • 6 of 8 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.018%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/sema/src/ty/mod.rs 6 8 75.0%
Totals Coverage Status
Change from base Build 9073127729: 0.0%
Covered Lines: 53493
Relevant Lines: 75323

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit b3bbfb9 into kcl-lang:main May 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] lsp hover content error
3 participants