Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix missing variables in api ListVariable() when list from KCL with unsupported expr #1315

Merged
merged 1 commit into from
May 15, 2024

Conversation

zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

…ith unsupported expr

Signed-off-by: zongz <zongzhe1024@163.com>
@zong-zhe zong-zhe added bug Something isn't working api Issues or PRs related to kcl rust native APIs and multi-lang APIs labels May 15, 2024
@zong-zhe zong-zhe added this to the v0.9.0 Release milestone May 15, 2024
@zong-zhe zong-zhe requested a review from Peefy May 15, 2024 06:02
@zong-zhe zong-zhe self-assigned this May 15, 2024
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 9090758265

Details

  • 21 of 22 (95.45%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.008%) to 71.03%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/query/src/selector.rs 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
kclvm/query/src/selector.rs 1 82.42%
Totals Coverage Status
Change from base Build 9089903111: 0.008%
Covered Lines: 53534
Relevant Lines: 75368

💛 - Coveralls

@Peefy Peefy merged commit a933717 into kcl-lang:main May 15, 2024
8 of 10 checks passed
@zong-zhe zong-zhe deleted the fix-list-var-with-if branch June 12, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issues or PRs related to kcl rust native APIs and multi-lang APIs bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants