Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add toolchain abstraction and add it into the language server state #1354

Merged
merged 2 commits into from
May 23, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented May 23, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • refactor: add toolchain abstraction and add it into the language server state

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/driver/src/lib.rs
  • kclvm/driver/src/tests.rs
  • kclvm/driver/src/toolchain.rs
  • kclvm/tools/src/LSP/src/completion.rs
  • kclvm/tools/src/LSP/src/find_refs.rs
  • kclvm/tools/src/LSP/src/notification.rs
  • kclvm/tools/src/LSP/src/quick_fix.rs
  • kclvm/tools/src/LSP/src/request.rs
  • kclvm/tools/src/LSP/src/state.rs
  • kclvm/tools/src/LSP/src/tests.rs
  • kclvm/tools/src/LSP/src/util.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@Peefy Peefy force-pushed the refactor-toolchain-in-kls branch from fdebd41 to 7babb77 Compare May 23, 2024 09:45
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

coveralls commented May 23, 2024

Pull Request Test Coverage Report for Build 9206751290

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 227 of 243 (93.42%) changed or added relevant lines in 18 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.08%) to 71.142%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/driver/src/lib.rs 12 13 92.31%
kclvm/tools/src/LSP/src/analysis.rs 0 1 0.0%
kclvm/tools/src/LSP/src/main.rs 0 1 0.0%
kclvm/tools/src/LSP/src/state.rs 9 11 81.82%
kclvm/driver/src/toolchain.rs 76 87 87.36%
Files with Coverage Reduction New Missed Lines %
kclvm/tools/src/LSP/src/state.rs 1 83.33%
Totals Coverage Status
Change from base Build 9202840451: 0.08%
Covered Lines: 53923
Relevant Lines: 75796

💛 - Coveralls

…er state

Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy force-pushed the refactor-toolchain-in-kls branch from 7babb77 to 71906e8 Compare May 23, 2024 10:19
Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy merged commit 2025bc7 into kcl-lang:main May 23, 2024
8 of 10 checks passed
@Peefy Peefy deleted the refactor-toolchain-in-kls branch May 23, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants