Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: runtime option function memory leak and add gc function calling the evaluator #1355

Merged
merged 1 commit into from
May 24, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented May 24, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix crossplane-contrib/function-kcl#108

fix: runtime option function memory leak and add gc function callingin the evluator

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/api/Cargo.toml
  • kclvm/runner/src/runner.rs
  • kclvm/runtime/src/api/kclvm.rs
  • kclvm/runtime/src/context/mod.rs
  • kclvm/runtime/src/stdlib/builtin.rs
  • kclvm/runtime/src/stdlib/builtin_api.rs
  • kclvm/runtime/src/value/iter.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

…in the evluator

Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy changed the title fix: runtime option function memory leak and add gc function callingin the evluator fix: runtime option function memory leak and add gc function calling the evaluator May 24, 2024
@coveralls
Copy link
Collaborator

coveralls commented May 24, 2024

Pull Request Test Coverage Report for Build 9217784869

Details

  • 16 of 34 (47.06%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.006%) to 71.148%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/runner/src/runner.rs 0 1 0.0%
kclvm/runtime/src/stdlib/builtin.rs 0 4 0.0%
kclvm/runtime/src/context/mod.rs 0 6 0.0%
kclvm/runtime/src/stdlib/builtin_api.rs 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
kclvm/runtime/src/stdlib/builtin.rs 1 56.0%
kclvm/runtime/src/stdlib/builtin_api.rs 1 2.0%
Totals Coverage Status
Change from base Build 9207089953: 0.006%
Covered Lines: 53912
Relevant Lines: 75774

💛 - Coveralls

@Peefy Peefy merged commit 6f9c637 into kcl-lang:main May 24, 2024
9 of 10 checks passed
@Peefy Peefy deleted the fix-runtime-option-function-mem-leak branch May 24, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function Pod High memory usage / Leak
2 participants