Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fixes for more compile errors #1360

Merged
merged 8 commits into from
May 26, 2024
Merged

Conversation

shashank-iitbhu
Copy link
Contributor

@shashank-iitbhu shashank-iitbhu commented May 25, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

Screen.Recording.2024-05-26.at.3.06.38.AM.mov
Screen.Recording.2024-05-26.at.3.12.23.AM.mov
Screen.Recording.2024-05-26.at.3.14.05.AM.mov
  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: Shashank Mittal <shashank.mittal.mec22@itbhu.ac.in>
Signed-off-by: Shashank Mittal <shashank.mittal.mec22@itbhu.ac.in>
Signed-off-by: Shashank Mittal <shashank.mittal.mec22@itbhu.ac.in>
Signed-off-by: Shashank Mittal <shashank.mittal.mec22@itbhu.ac.in>
@shashank-iitbhu
Copy link
Contributor Author

Added a few more quick fixes, please review @Peefy

Signed-off-by: Shashank Mittal <shashank.mittal.mec22@itbhu.ac.in>
Signed-off-by: Shashank Mittal <shashank.mittal.mec22@itbhu.ac.in>
@coveralls
Copy link
Collaborator

coveralls commented May 25, 2024

Pull Request Test Coverage Report for Build 9244984919

Details

  • 37 of 60 (61.67%) changed or added relevant lines in 4 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.002%) to 71.215%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/sema/src/resolver/schema.rs 0 2 0.0%
kclvm/sema/src/resolver/arg.rs 8 13 61.54%
kclvm/sema/src/resolver/global.rs 0 16 0.0%
Files with Coverage Reduction New Missed Lines %
kclvm/sema/src/resolver/global.rs 2 71.22%
kclvm/sema/src/resolver/arg.rs 3 75.0%
Totals Coverage Status
Change from base Build 9237078502: 0.002%
Covered Lines: 54310
Relevant Lines: 76262

💛 - Coveralls

Signed-off-by: Shashank Mittal <shashank.mittal.mec22@itbhu.ac.in>
@shashank-iitbhu
Copy link
Contributor Author

Screen.Recording.2024-05-26.at.10.40.45.PM.mov

Got caught up with something, will implement the following in the next commit, the suggestions from #1133 (comment) and the fix for :

f = lambda x: int {
    x
}
a = f(x = 1, b)

which is an Invalid syntax error with the message positional argument follows keyword argument.

Signed-off-by: Shashank Mittal <shashank.mittal.mec22@itbhu.ac.in>
@Peefy Peefy merged commit 16d0d10 into kcl-lang:main May 26, 2024
8 of 10 checks passed
@shashank-iitbhu shashank-iitbhu mentioned this pull request May 27, 2024
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants