Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: evaluator runtime schema type get attr and type cast #1425

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jun 20, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix: #1417

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/evaluator/src/node.rs
  • kclvm/evaluator/src/schema.rs
  • kclvm/evaluator/src/ty.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • test/grammar/import/import_with_complex_types_0/main.k
  • test/grammar/import/import_with_complex_types_1/main.k

Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy merged commit 63b2368 into kcl-lang:main Jun 20, 2024
11 checks passed
@Peefy Peefy deleted the fix-evaluator-runtime-type-cast branch June 20, 2024 10:35
@coveralls
Copy link
Collaborator

coveralls commented Jun 20, 2024

Pull Request Test Coverage Report for Build 9595487362

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 18 of 75 (24.0%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 71.251%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/evaluator/src/node.rs 0 2 0.0%
kclvm/evaluator/src/schema.rs 18 73 24.66%
Files with Coverage Reduction New Missed Lines %
kclvm/evaluator/src/node.rs 1 65.24%
kclvm/evaluator/src/schema.rs 3 58.51%
Totals Coverage Status
Change from base Build 9595215816: -0.02%
Covered Lines: 55613
Relevant Lines: 78052

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The implicit type specification issue (KCL_FAST_EVAL=1)
2 participants