Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: file.modpath and file.workdir function cache cross different modules #1427

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jun 20, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix #1421

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/compiler/src/codegen/llvm/context.rs
  • kclvm/version/src/lib.rs

@Peefy Peefy merged commit 6fd3a09 into kcl-lang:main Jun 20, 2024
9 of 11 checks passed
@Peefy Peefy deleted the fix-file-modpath-and-workdir-set branch June 20, 2024 11:20
@coveralls
Copy link
Collaborator

coveralls commented Jun 20, 2024

Pull Request Test Coverage Report for Build 9596207228

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 14 of 14 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 71.252%

Totals Coverage Status
Change from base Build 9595967845: 0.001%
Covered Lines: 55614
Relevant Lines: 78053

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

argocd kcl plugin rendering is slow and file.modpath is cached by different kcl modules
2 participants