-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(Compiler-Base): Add diagnostic handler. #170
Conversation
add diagnostic handler in compiler_base/error/lib.rs. issue #115
Pull Request Test Coverage Report for Build 2968688349
💛 - Coveralls |
Two important things:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
issue #115
2. What is the scope of this PR (e.g. component or file name):
add diagnostic handler in compiler_base/error/lib.rs.
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
Turn
TemplateLoader
completely into a private crate forDiagnosticHandler
.Move some comments from
TemplateLoader
toDiagnosticHandler
.Move
MessageArgs
form 'compiler_base/error/diagnostic_message.rs' to 'compiler_base/error/lib.rs'.Add
DiagnosticHandler
in 'compiler_base/error/lib.rs'.4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
test cases in 'compiler_base/error/tests.rs'.
6. Release note
Please refer to Release Notes Language Style Guide to write a quality release note.