Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support call kclvm service by go rpc server #173

Merged
merged 2 commits into from
Aug 31, 2022

Conversation

NeverRaR
Copy link
Contributor

@NeverRaR NeverRaR commented Aug 31, 2022

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

internal/kclvm_py/scripts/
kclvm/capi/src/service/service.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other
    chorm: build kclvm capi lib and cpython shared lib for kclvm

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

internal/kclvm_py/scripts/update-kclvm.sh Outdated Show resolved Hide resolved
internal/kclvm_py/scripts/update-kclvm.sh Outdated Show resolved Hide resolved
gorpc/main.go Outdated Show resolved Hide resolved
@coveralls
Copy link
Collaborator

coveralls commented Aug 31, 2022

Pull Request Test Coverage Report for Build 2961795614

  • 7 of 12 (58.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 60.433%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/capi/src/service/service.rs 7 12 58.33%
Totals Coverage Status
Change from base Build 2961727829: -0.004%
Covered Lines: 23789
Relevant Lines: 39364

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chai2010 chai2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chai2010 chai2010 merged commit 1418db3 into kcl-lang:main Aug 31, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants