Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(kclvm-tools): move 'printer' from 'kclvm-tools' to 'kclvm-ast'. #228

Merged
merged 5 commits into from Oct 9, 2022
Merged

Refactor(kclvm-tools): move 'printer' from 'kclvm-tools' to 'kclvm-ast'. #228

merged 5 commits into from Oct 9, 2022

Conversation

zong-zhe
Copy link
Contributor

@zong-zhe zong-zhe commented Oct 8, 2022

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

issue #67

2. What is the scope of this PR (e.g. component or file name):

kclvm-tools
kclvm-ast

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

move 'printer' from 'kclvm-tools' to 'kclvm-ast'

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@zong-zhe zong-zhe added this to the v0.4.4 Release milestone Oct 8, 2022
@zong-zhe zong-zhe self-assigned this Oct 8, 2022
Peefy
Peefy previously approved these changes Oct 8, 2022
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

He1pa
He1pa previously approved these changes Oct 8, 2022
Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zong-zhe zong-zhe dismissed stale reviews from He1pa and Peefy via b15d822 October 8, 2022 12:28
@coveralls
Copy link
Collaborator

coveralls commented Oct 8, 2022

Pull Request Test Coverage Report for Build 3210438926

  • 11 of 11 (100.0%) changed or added relevant lines in 2 files are covered.
  • 500 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+1.008%) to 60.882%

Files with Coverage Reduction New Missed Lines %
kclvm/ast/src/token_stream.rs 1 75.0%
kclvm/sema/src/resolver/global.rs 15 61.42%
kclvm/sema/src/resolver/scope.rs 72 60.0%
kclvm/parser/src/parser/stmt.rs 127 88.87%
kclvm/parser/src/parser/expr.rs 285 81.58%
Totals Coverage Status
Change from base Build 3209496886: 1.008%
Covered Lines: 23230
Relevant Lines: 38156

💛 - Coveralls

Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zong-zhe zong-zhe merged commit 5f7a002 into kcl-lang:main Oct 9, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants