Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(kclvm-parser): return loading file failed error message from meth… #237

Merged
merged 1 commit into from Oct 12, 2022
Merged

Fix(kclvm-parser): return loading file failed error message from meth… #237

merged 1 commit into from Oct 12, 2022

Conversation

zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

issue #236

2. What is the scope of this PR (e.g. component or file name):

kclvm-parser

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

Use match replace unwrap.
And the error of loading the file is returned by the return value.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

…od `parse_file`.

use `match` replace `unwrap`.

issue #236
@zong-zhe zong-zhe added bug Something isn't working fix labels Oct 12, 2022
@zong-zhe zong-zhe added this to the v0.4.4 Release milestone Oct 12, 2022
@zong-zhe zong-zhe self-assigned this Oct 12, 2022
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 3231683001

  • 12 of 13 (92.31%) changed or added relevant lines in 2 files are covered.
  • 150 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.3%) to 60.111%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/parser/src/parser/tests.rs 6 7 85.71%
Files with Coverage Reduction New Missed Lines %
kclvm/runner/src/assembler.rs 1 97.86%
kclvm/sema/src/ty/context.rs 1 93.2%
kclvm/sema/src/resolver/node.rs 9 75.23%
kclvm/sema/src/resolver/config.rs 42 79.61%
kclvm/3rdparty/rustc_span/src/analyze_source_file.rs 48 75.26%
kclvm/parser/src/lib.rs 49 85.2%
Totals Coverage Status
Change from base Build 3226038526: 0.3%
Covered Lines: 21964
Relevant Lines: 36539

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chai2010 chai2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zong-zhe zong-zhe merged commit 3cdb489 into kcl-lang:main Oct 12, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants