Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(compiler_base):add codecov for compiler_base in CI. #248

Merged
merged 5 commits into from
Oct 21, 2022
Merged

Feat(compiler_base):add codecov for compiler_base in CI. #248

merged 5 commits into from
Oct 21, 2022

Conversation

zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

issue #115

2. What is the scope of this PR (e.g. component or file name):

compiler_base

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

add codecov for compiler_base in CI.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@coveralls
Copy link
Collaborator

coveralls commented Oct 19, 2022

Pull Request Test Coverage Report for Build 3294146385

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 121 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.04%) to 60.079%

Files with Coverage Reduction New Missed Lines %
kclvm/parser/src/parser/stmt.rs 1 88.78%
kclvm/sema/src/resolver/global.rs 1 61.42%
kclvm/sema/src/ty/mod.rs 1 66.02%
kclvm/sema/src/resolver/node.rs 3 68.94%
kclvm/sema/src/resolver/scope.rs 6 61.67%
kclvm/sema/src/ty/unify.rs 7 93.91%
kclvm/3rdparty/rustc_span/src/analyze_source_file.rs 48 75.26%
kclvm/parser/src/lib.rs 54 83.69%
Totals Coverage Status
Change from base Build 3286286832: 0.04%
Covered Lines: 21683
Relevant Lines: 36091

💛 - Coveralls

@Peefy
Copy link
Contributor

Peefy commented Oct 19, 2022

Considering a new single github workflow to fully test compiler_base with OS matrixes including ubuntu, macos, windows, etc.

@github-actions
Copy link

github-actions bot commented Oct 20, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zong-zhe zong-zhe merged commit e72e74b into kcl-lang:main Oct 21, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci enhancement New feature or request feat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants