Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reduce binaries size, remove internal python #303

Merged
merged 1 commit into from Nov 22, 2022

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Nov 22, 2022

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Peefy Peefy added this to the v0.4.4 Release milestone Nov 22, 2022
@Peefy Peefy self-assigned this Nov 22, 2022
@coveralls
Copy link
Collaborator

coveralls commented Nov 22, 2022

Pull Request Test Coverage Report for Build 3520333592

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.712%

Totals Coverage Status
Change from base Build 3514133864: 0.0%
Covered Lines: 1369
Relevant Lines: 1526

💛 - Coveralls

Copy link
Contributor

@chai2010 chai2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@NeverRaR NeverRaR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 96efc80 into kcl-lang:main Nov 22, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2022
@Peefy Peefy deleted the refactor-remove-py branch January 16, 2023 12:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants