Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config if entry type unsoundness #391

Merged
merged 2 commits into from
Jan 30, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jan 30, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Fixes #389

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/sema/src/resolver/config.rs
  • kclvm/sema/src/resolver/node.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • test/grammar/types/var_type_annotation/type_fail_13/main.k
  • test/grammar/types/var_type_annotation/type_fail_14/main.k

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Peefy Peefy added bug Something isn't working type-system Issues or PRs related to kcl type system resolver labels Jan 30, 2023
@Peefy Peefy added this to the v0.4.5 Release milestone Jan 30, 2023
@Peefy Peefy self-assigned this Jan 30, 2023
@coveralls
Copy link
Collaborator

coveralls commented Jan 30, 2023

Pull Request Test Coverage Report for Build 4040552390

  • 86 of 124 (69.35%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-28.09%) to 62.472%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/sema/src/resolver/config.rs 68 106 64.15%
Totals Coverage Status
Change from base Build 4036676922: -28.09%
Covered Lines: 23214
Relevant Lines: 37159

💛 - Coveralls

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zong-zhe zong-zhe merged commit 00e207b into kcl-lang:main Jan 30, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2023
@Peefy Peefy deleted the fix-config-if-entry-type-unsoundness branch January 30, 2023 09:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working resolver type-system Issues or PRs related to kcl type system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Type unsoundness in config if entries
4 participants