Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refine code to fix cargo update break issues and warnings #399

Merged
merged 1 commit into from Feb 3, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Feb 2, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix #398

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/runtime/src/datetime/datetime.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

All test cases.

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@coveralls
Copy link
Collaborator

coveralls commented Feb 2, 2023

Pull Request Test Coverage Report for Build 4080586662

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-29.8%) to 60.724%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/runtime/src/datetime/datetime.rs 0 2 0.0%
Totals Coverage Status
Change from base Build 4080571330: -29.8%
Covered Lines: 20124
Relevant Lines: 33140

💛 - Coveralls

@Peefy Peefy mentioned this pull request Feb 2, 2023
@Peefy Peefy force-pushed the refactor-code-with-cargo-update branch from e82d17e to 068a785 Compare February 3, 2023 02:40
@Peefy Peefy changed the title refactor: refine code to fix cargo update break issues. refactor: refine code to fix cargo update break issues and warnings Feb 3, 2023
@Peefy Peefy self-assigned this Feb 3, 2023
@Peefy Peefy added this to the v0.4.5 Release milestone Feb 3, 2023
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zong-zhe zong-zhe merged commit 6c172ba into kcl-lang:main Feb 3, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2023
@Peefy Peefy deleted the refactor-code-with-cargo-update branch February 3, 2023 06:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo update breaks build
4 participants