Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: settings file loader errors and add the kclvm cmd crate & remove deprecated codes. #402

Merged
merged 1 commit into from Feb 6, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Feb 6, 2023

…emove deprecated codes.

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

The reason for this PR is for subsequent CLI refactoring and Parser Error refactoring. Associated issues:

The reason for this PR is to better reconstruct the CLI and Parser errors in the future.

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

All grammar and unit test cases.

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Peefy Peefy added error-handling Issues or PRs related to kcl error handling refactor labels Feb 6, 2023
@Peefy Peefy self-assigned this Feb 6, 2023
@coveralls
Copy link
Collaborator

coveralls commented Feb 6, 2023

Pull Request Test Coverage Report for Build 4100366581

  • 38 of 196 (19.39%) changed or added relevant lines in 14 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-28.3%) to 62.271%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/sema/src/resolver/scope.rs 2 3 66.67%
kclvm/src/main.rs 0 1 0.0%
kclvm/error/src/lib.rs 0 3 0.0%
kclvm/config/src/settings.rs 28 37 75.68%
kclvm/error/src/diagnostic.rs 0 12 0.0%
kclvm/cmd/src/run.rs 0 18 0.0%
kclvm/cmd/src/lint.rs 0 21 0.0%
kclvm/error/src/emitter.rs 0 23 0.0%
kclvm/cmd/src/lib.rs 1 33 3.03%
kclvm/cmd/src/settings.rs 0 38 0.0%
Totals Coverage Status
Change from base Build 4100192361: -28.3%
Covered Lines: 21484
Relevant Lines: 34501

💛 - Coveralls

@Peefy Peefy added this to the v0.4.5 Release milestone Feb 6, 2023
@Peefy Peefy merged commit e1dec1e into kcl-lang:main Feb 6, 2023
@Peefy Peefy deleted the refactor-cli-error branch February 6, 2023 09:29
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
error-handling Issues or PRs related to kcl error handling refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants