Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support config mutref except arguments. #413

Merged
merged 1 commit into from Feb 14, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Feb 14, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

feat: #368

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • test/grammar/datatype/dict/mutual_ref_13/main.k

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Peefy Peefy added semantic Issues or PRs related to kcl semantic and checker codegen labels Feb 14, 2023
@Peefy Peefy added this to the v0.4.5 Release milestone Feb 14, 2023
@Peefy Peefy self-assigned this Feb 14, 2023
@coveralls
Copy link
Collaborator

coveralls commented Feb 14, 2023

Pull Request Test Coverage Report for Build 4171985317

  • 18 of 18 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-27.9%) to 62.646%

Totals Coverage Status
Change from base Build 4171796811: -27.9%
Covered Lines: 22850
Relevant Lines: 36475

💛 - Coveralls

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit f6f1aa3 into kcl-lang:main Feb 14, 2023
@Peefy Peefy deleted the feat-config-mutref-except-args branch February 14, 2023 09:23
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
codegen semantic Issues or PRs related to kcl semantic and checker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants