Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add konfig integration tests on the format tool, fix test suites and add more unit test suites. #417

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Feb 20, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re: #372

test: add integration tests on the format tool and fix test suites.

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • Unit test: test_format_source at kclvm/tools/src/format/tests.rs
  • Konfig integration test: test_format_integration_konfig at kclvm/tools/src/format/tests.rs

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Peefy Peefy added tool Issues or PRs related to kcl tools inlucding format, lint, validation, document tools, etc. test labels Feb 20, 2023
@Peefy Peefy added this to the v0.4.5 Release milestone Feb 20, 2023
@Peefy Peefy self-assigned this Feb 20, 2023
@Peefy Peefy force-pushed the ast-printer-konfig-integration-test branch from c30adc2 to 717ab49 Compare February 20, 2023 12:03
@coveralls
Copy link
Collaborator

coveralls commented Feb 20, 2023

Pull Request Test Coverage Report for Build 4223594545

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.562%

Totals Coverage Status
Change from base Build 4223409841: 0.0%
Covered Lines: 1612
Relevant Lines: 1780

💛 - Coveralls

NeverRaR
NeverRaR previously approved these changes Feb 20, 2023
Copy link
Contributor

@NeverRaR NeverRaR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 8a2bd50 into kcl-lang:main Feb 21, 2023
@Peefy Peefy deleted the ast-printer-konfig-integration-test branch February 21, 2023 02:31
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
test tool Issues or PRs related to kcl tools inlucding format, lint, validation, document tools, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants