Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: using compiler base session in the kclvm parser to prepare for the parser error recovery. #438

Merged
merged 2 commits into from
Mar 8, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Mar 8, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re: #420. Using compiler base session in the kclvm parser to prepare for the parser error recovery.

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

All kclvm parser unit tests and grammar tests.

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Peefy Peefy added parser Issues or PRs related to kcl parser refactor labels Mar 8, 2023
@Peefy Peefy added this to the v0.4.6 Release milestone Mar 8, 2023
@Peefy Peefy self-assigned this Mar 8, 2023
@coveralls
Copy link
Collaborator

coveralls commented Mar 8, 2023

Pull Request Test Coverage Report for Build 4361749882

  • 178 of 212 (83.96%) changed or added relevant lines in 18 files are covered.
  • 41 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-27.0%) to 63.583%

Changes Missing Coverage Covered Lines Changed/Added Lines %
compiler_base/session/src/lib.rs 6 7 85.71%
kclvm/cmd/src/lib.rs 0 2 0.0%
kclvm/cmd/src/lint.rs 0 2 0.0%
kclvm/src/main.rs 0 2 0.0%
kclvm/error/src/lib.rs 25 30 83.33%
kclvm/parser/src/lib.rs 47 52 90.38%
kclvm/src/lib.rs 0 6 0.0%
kclvm/cmd/src/run.rs 0 11 0.0%
Files with Coverage Reduction New Missed Lines %
compiler_base/session/src/lib.rs 41 25.0%
Totals Coverage Status
Change from base Build 4353413521: -27.0%
Covered Lines: 21860
Relevant Lines: 34380

💛 - Coveralls

@Peefy Peefy force-pushed the use-compiler-base-err-in-parser branch from 63b93d9 to 242f10b Compare March 8, 2023 06:07
@Peefy Peefy force-pushed the use-compiler-base-err-in-parser branch from 242f10b to af996f3 Compare March 8, 2023 06:25
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zong-zhe zong-zhe merged commit 6674a71 into kcl-lang:main Mar 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
parser Issues or PRs related to kcl parser refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants