Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add lock in the global session interner for parallel parser. #464

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Mar 24, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

feat: add lock in the global session interner for parallel parser.

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • kclvm/runner/src/tests.rs

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Peefy Peefy added the session label Mar 24, 2023
@Peefy Peefy added this to the v0.4.6 Release milestone Mar 24, 2023
@Peefy Peefy self-assigned this Mar 24, 2023
@coveralls
Copy link
Collaborator

coveralls commented Mar 24, 2023

Pull Request Test Coverage Report for Build 4507599367

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.313%

Totals Coverage Status
Change from base Build 4489145643: 0.0%
Covered Lines: 2106
Relevant Lines: 2358

💛 - Coveralls

@Peefy Peefy merged commit 2542317 into kcl-lang:main Mar 24, 2023
@Peefy Peefy deleted the feat-add-lock-global-sess branch March 24, 2023 06:53
@github-actions github-actions bot locked and limited conversation to collaborators Mar 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants