Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix(Parser): If expr position error #480

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Apr 3, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

Parser

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

Bugfix: If expr position error

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@He1pa He1pa added the bug Something isn't working label Apr 3, 2023
@He1pa He1pa self-assigned this Apr 3, 2023
@He1pa He1pa changed the title Bugfix: If stmt position error Bugfix: If expr position error Apr 3, 2023
@coveralls
Copy link
Collaborator

coveralls commented Apr 3, 2023

Pull Request Test Coverage Report for Build 4595572831

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 36 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-22.4%) to 65.582%

Files with Coverage Reduction New Missed Lines %
compiler_base/session/src/lib.rs 36 37.1%
Totals Coverage Status
Change from base Build 4595027486: -22.4%
Covered Lines: 25101
Relevant Lines: 38274

💛 - Coveralls

@He1pa He1pa changed the title Bugfix: If expr position error Bugfix(Parser): If expr position error Apr 3, 2023
@Peefy Peefy added the parser Issues or PRs related to kcl parser label Apr 3, 2023
@Peefy Peefy added this to the v0.4.6 Release milestone Apr 3, 2023
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit fca0342 into kcl-lang:main Apr 3, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working parser Issues or PRs related to kcl parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants