Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: invalid comp clause parse and sematic error recovery. #497

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Apr 10, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #420

feat: invalid comp clause parse and sematic error recovery.

2. What is the scope of this PR (e.g. component or file name):

  • kclvm_parser crate
  • kclvm_sema crate

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • kclvm/parser/src/tests/error_recovery.rs
  • kclvm/sema/src/resolver/tests.rs

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Peefy Peefy added parser Issues or PRs related to kcl parser semantic Issues or PRs related to kcl semantic and checker error-handling Issues or PRs related to kcl error handling labels Apr 10, 2023
@Peefy Peefy added this to the v0.4.6 Release milestone Apr 10, 2023
@Peefy Peefy self-assigned this Apr 10, 2023
@coveralls
Copy link
Collaborator

coveralls commented Apr 10, 2023

Pull Request Test Coverage Report for Build 4655134221

  • 73 of 99 (73.74%) changed or added relevant lines in 3 files are covered.
  • 31 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-20.9%) to 67.104%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/sema/src/resolver/node.rs 18 30 60.0%
kclvm/parser/src/parser/expr.rs 52 66 78.79%
Files with Coverage Reduction New Missed Lines %
compiler_base/session/src/lib.rs 31 45.16%
Totals Coverage Status
Change from base Build 4655096333: -20.9%
Covered Lines: 29195
Relevant Lines: 43507

💛 - Coveralls

Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Peefy Peefy merged commit a0b9ede into kcl-lang:main Apr 10, 2023
@Peefy Peefy deleted the feat-comp-clause-err-recovery branch April 10, 2023 10:01
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
error-handling Issues or PRs related to kcl error handling parser Issues or PRs related to kcl parser semantic Issues or PRs related to kcl semantic and checker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants