Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: if_stmt orelse postion #612

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Jul 20, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

parser

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

fix position err in if_stmt orelse

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@He1pa He1pa self-assigned this Jul 20, 2023
@He1pa He1pa added ast parser Issues or PRs related to kcl parser and removed ast labels Jul 20, 2023
@He1pa He1pa mentioned this pull request Jul 20, 2023
10 tasks
@He1pa He1pa force-pushed the fix_ifstmt_orelse_pos branch 2 times, most recently from 69080f4 to 582680b Compare July 20, 2023 03:19
@Peefy Peefy merged commit b20aa9f into kcl-lang:main Jul 20, 2023
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
parser Issues or PRs related to kcl parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants