Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix schema attr position in sema type #674

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Aug 21, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

sema/type

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

fix schema attr position in sema type.

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@He1pa He1pa marked this pull request as ready for review August 21, 2023 06:04
@He1pa He1pa self-assigned this Aug 21, 2023
@He1pa He1pa added bug Something isn't working lsp labels Aug 21, 2023
@Peefy Peefy added the resolver label Aug 21, 2023
@Peefy Peefy added this to the v0.6.0 Release milestone Aug 21, 2023
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 5922590325

  • 20 of 20 (100.0%) changed or added relevant lines in 3 files are covered.
  • 26 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-18.4%) to 69.58%

Files with Coverage Reduction New Missed Lines %
compiler_base/session/src/lib.rs 26 58.06%
Totals Coverage Status
Change from base Build 5903534173: -18.4%
Covered Lines: 32843
Relevant Lines: 47202

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit a19eb7b into kcl-lang:main Aug 21, 2023
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working lsp resolver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants