Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : namer for new architecture of semantic model #762

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

NeverRaR
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #742

2. What is the scope of this PR (e.g. component or file name):

kclvm/sema/core
kclvm/sema/namer

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

support namer for new architecture of semantic model

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@coveralls
Copy link
Collaborator

coveralls commented Oct 13, 2023

Pull Request Test Coverage Report for Build 6570502372

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.82%

Totals Coverage Status
Change from base Build 6562245967: 0.0%
Covered Lines: 2300
Relevant Lines: 2619

💛 - Coveralls

@NeverRaR NeverRaR added semantic Issues or PRs related to kcl semantic and checker arch labels Oct 13, 2023
@NeverRaR NeverRaR requested a review from Peefy October 13, 2023 06:22
@Peefy Peefy added this to the v0.7.0 Release milestone Oct 13, 2023
@Peefy Peefy requested a review from i-zhen October 13, 2023 09:10
kclvm/sema/src/namer/mod.rs Outdated Show resolved Hide resolved
kclvm/sema/src/namer/node.rs Outdated Show resolved Hide resolved
kclvm/sema/src/core/symbol.rs Outdated Show resolved Hide resolved
kclvm/sema/src/core/symbol.rs Outdated Show resolved Hide resolved
kclvm/sema/src/core/symbol.rs Show resolved Hide resolved
kclvm/sema/src/core/symbol.rs Show resolved Hide resolved
kclvm/sema/src/core/symbol.rs Show resolved Hide resolved
kclvm/sema/src/core/symbol.rs Show resolved Hide resolved
kclvm/sema/src/core/symbol.rs Show resolved Hide resolved
kclvm/sema/src/core/symbol.rs Show resolved Hide resolved
kclvm/sema/src/namer/mod.rs Show resolved Hide resolved
Signed-off-by: never <chenxiangfei.cxf@antgroup.com>
kclvm/sema/src/namer/mod.rs Outdated Show resolved Hide resolved
Signed-off-by: never <chenxiangfei.cxf@antgroup.com>
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit e0dd228 into kcl-lang:main Oct 20, 2023
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch semantic Issues or PRs related to kcl semantic and checker
Projects
No open projects
Status: v0.7.0 Release Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants