Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the error message according to singular or even #769

Merged
merged 3 commits into from Oct 16, 2023
Merged

fix: fix the error message according to singular or even #769

merged 3 commits into from Oct 16, 2023

Conversation

zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Fixed #768

2. What is the scope of this PR (e.g. component or file name):

kclvm/sema/src/resolver/arg.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

Each time before the output error message, calculate the output error message specific content.

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: zongz <zongzhe1024@163.com>
@zong-zhe zong-zhe added bug Something isn't working error-handling Issues or PRs related to kcl error handling labels Oct 16, 2023
@zong-zhe zong-zhe added this to the v0.7.0 Release milestone Oct 16, 2023
@zong-zhe zong-zhe requested review from i-zhen and Peefy October 16, 2023 07:33
@zong-zhe zong-zhe self-assigned this Oct 16, 2023
Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
@coveralls
Copy link
Collaborator

coveralls commented Oct 16, 2023

Pull Request Test Coverage Report for Build 6530792163

  • 22 of 22 (100.0%) changed or added relevant lines in 3 files are covered.
  • 471 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-17.5%) to 70.507%

Files with Coverage Reduction New Missed Lines %
compiler_base/error/src/diagnostic/components.rs 6 0.0%
compiler_base/error/src/errors.rs 8 0.0%
compiler_base/session/src/lib.rs 26 58.06%
compiler_base/error/src/diagnostic/mod.rs 27 0.0%
compiler_base/error/src/diagnostic/style.rs 41 0.0%
compiler_base/error/src/diagnostic/diagnostic_message.rs 74 0.0%
compiler_base/error/src/emitter.rs 119 0.0%
compiler_base/error/src/diagnostic/diagnostic_handler.rs 170 0.0%
Totals Coverage Status
Change from base Build 6507361361: -17.5%
Covered Lines: 36325
Relevant Lines: 51520

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 6ac730d into kcl-lang:main Oct 16, 2023
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working error-handling Issues or PRs related to kcl error handling
Projects
No open projects
Status: v0.7.0 Release Done
Development

Successfully merging this pull request may close these issues.

bug: singular/even numbers error in some diagnostics
3 participants