Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add advenced resolver for new semantic modle #808

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

NeverRaR
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #780

2. What is the scope of this PR (e.g. component or file name):

kclvm/ast/src/ast.rs
kclvm/ast/src/pos.rs
kclvm/sema/src/advanced_resolver
kclvm/sema/src/core

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

feat: add advenced resolver for new semantic modle

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@Peefy Peefy added this to the v0.7.0 Release milestone Oct 26, 2023
@NeverRaR NeverRaR force-pushed the dev/boying/advanced_resolver branch 2 times, most recently from 72376a7 to bb0d88d Compare October 26, 2023 12:42
@NeverRaR NeverRaR requested review from Peefy and He1pa and removed request for Peefy October 26, 2023 12:49
@coveralls
Copy link
Collaborator

coveralls commented Oct 26, 2023

Pull Request Test Coverage Report for Build 6662636077

  • 2049 of 3196 (64.11%) changed or added relevant lines in 32 files are covered.
  • 471 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-18.2%) to 69.597%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/ast/src/ast.rs 5 6 83.33%
kclvm/sema/src/resolver/node.rs 49 50 98.0%
kclvm/sema/src/resolver/var.rs 19 20 95.0%
kclvm/sema/src/ty/context.rs 9 10 90.0%
kclvm/sema/src/resolver/global.rs 7 9 77.78%
kclvm/ast/src/pos.rs 0 3 0.0%
kclvm/sema/src/core/semantic_information.rs 27 30 90.0%
kclvm/sema/src/ty/parser.rs 2 6 33.33%
kclvm/sema/src/namer/node.rs 34 39 87.18%
kclvm/sema/src/core/package.rs 20 29 68.97%
Files with Coverage Reduction New Missed Lines %
compiler_base/error/src/diagnostic/components.rs 6 0.0%
compiler_base/error/src/errors.rs 8 0.0%
compiler_base/session/src/lib.rs 26 58.06%
compiler_base/error/src/diagnostic/mod.rs 27 0.0%
compiler_base/error/src/diagnostic/style.rs 41 0.0%
compiler_base/error/src/diagnostic/diagnostic_message.rs 74 0.0%
compiler_base/error/src/emitter.rs 119 0.0%
compiler_base/error/src/diagnostic/diagnostic_handler.rs 170 0.0%
Totals Coverage Status
Change from base Build 6662104557: -18.2%
Covered Lines: 38086
Relevant Lines: 54724

💛 - Coveralls

@NeverRaR NeverRaR force-pushed the dev/boying/advanced_resolver branch 2 times, most recently from 5923de7 to 6f97aae Compare October 26, 2023 14:01
kclvm/sema/src/advanced_resolver/mod.rs Show resolved Hide resolved
kclvm/sema/src/advanced_resolver/mod.rs Outdated Show resolved Hide resolved
kclvm/sema/src/advanced_resolver/mod.rs Outdated Show resolved Hide resolved
kclvm/sema/src/advanced_resolver/mod.rs Outdated Show resolved Hide resolved
kclvm/sema/src/advanced_resolver/mod.rs Show resolved Hide resolved
kclvm/sema/src/advanced_resolver/mod.rs Outdated Show resolved Hide resolved
kclvm/sema/src/advanced_resolver/mod.rs Outdated Show resolved Hide resolved
@NeverRaR NeverRaR force-pushed the dev/boying/advanced_resolver branch 2 times, most recently from 7414430 to f796ef9 Compare October 27, 2023 03:03
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: never <chenxiangfei.cxf@antgroup.com>
Signed-off-by: never <chenxiangfei.cxf@antgroup.com>
@Peefy Peefy merged commit 3e0b251 into kcl-lang:main Oct 27, 2023
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants