Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: completion for schema attr value. #809

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Oct 26, 2023

Completion when input = or : in config schema attr, and completion item contains primitiver type, literal, schema, list, dict, union

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

lsp completion

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

Completion when input = or : in config schema attr, and completion item contains primitiver type, literal, schema, list, dict, union

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@He1pa He1pa self-assigned this Oct 26, 2023
@He1pa He1pa added the lsp label Oct 26, 2023
@He1pa He1pa added this to the v0.7.0 Release milestone Oct 26, 2023
…in config schema attr, and completion item contains primitiver type, literal, schema, list, dict, union

Signed-off-by: He1pa <18012015693@163.com>
@He1pa He1pa force-pushed the feat_lsp_attr_value_completion branch from 067d396 to fc33e40 Compare October 26, 2023 13:30
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 6aef1a2 into kcl-lang:main Oct 27, 2023
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
Status: v0.7.0 Release Done
Development

Successfully merging this pull request may close these issues.

[Enhancement][track] completion on the right side value of the assignment statement
2 participants