-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate lsp goto_def to new sema model. #825
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peefy
reviewed
Nov 1, 2023
Pull Request Test Coverage Report for Build 6728841555
💛 - Coveralls |
Peefy
reviewed
Nov 1, 2023
Peefy
reviewed
Nov 1, 2023
1. use goto_definition_with_gs replace goto_definition and deprecated some functions in goto_def 2. add a resolve option `type_alias` to skip type_alias pass in lsp Signed-off-by: He1pa <18012015693@163.com>
Signed-off-by: He1pa <18012015693@163.com>
45f4325
to
fb08f99
Compare
Peefy
reviewed
Nov 2, 2023
Signed-off-by: He1pa <18012015693@163.com>
c0623a5
to
74b8b06
Compare
Peefy
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
goto_definition_with_gs
replacegoto_definition
and deprecated some functions in goto_deftype_alias
to skip type_alias pass in lsp1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
sema/resolvar/mod.rs
lsp/goto_def.rs
lsp/util.rs
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
goto_definition_with_gs
replacegoto_definition
and deprecated some functions in goto_deftype_alias
to skip type_alias pass in lsp4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: