Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate lsp goto_def to new sema model. #825

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Nov 1, 2023

  1. use goto_definition_with_gs replace goto_definition and deprecated some functions in goto_def
  2. add a resolve option type_alias to skip type_alias pass in lsp

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

sema/resolvar/mod.rs
lsp/goto_def.rs
lsp/util.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  1. use goto_definition_with_gs replace goto_definition and deprecated some functions in goto_def
  2. add a resolve option type_alias to skip type_alias pass in lsp
  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@He1pa He1pa self-assigned this Nov 1, 2023
@He1pa He1pa added the lsp label Nov 1, 2023
@He1pa He1pa added this to the v0.7.0 Release milestone Nov 1, 2023
kclvm/sema/src/advanced_resolver/mod.rs Outdated Show resolved Hide resolved
kclvm/sema/src/advanced_resolver/mod.rs Outdated Show resolved Hide resolved
kclvm/sema/src/advanced_resolver/mod.rs Show resolved Hide resolved
kclvm/sema/src/core/package.rs Show resolved Hide resolved
@coveralls
Copy link
Collaborator

coveralls commented Nov 1, 2023

Pull Request Test Coverage Report for Build 6728841555

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.82%

Totals Coverage Status
Change from base Build 6721267199: 0.0%
Covered Lines: 2300
Relevant Lines: 2619

💛 - Coveralls

1. use goto_definition_with_gs replace goto_definition and deprecated some functions in goto_def
2. add a resolve option `type_alias` to skip type_alias pass in lsp

Signed-off-by: He1pa <18012015693@163.com>
Signed-off-by: He1pa <18012015693@163.com>
@He1pa He1pa force-pushed the migrate_gotodef_to_new_sema_modle branch from 45f4325 to fb08f99 Compare November 2, 2023 02:36
Signed-off-by: He1pa <18012015693@163.com>
@He1pa He1pa force-pushed the migrate_gotodef_to_new_sema_modle branch from c0623a5 to 74b8b06 Compare November 2, 2023 05:53
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 22aaecf into kcl-lang:main Nov 2, 2023
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
Status: v0.7.0 Release Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants