Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rename, renameCode API #843

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

amyXia1994
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

feat: add rename, renameCode API

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: xiarui.xr <xiarui1994@gmail.com>
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 6743440424

  • 41 of 41 (100.0%) changed or added relevant lines in 3 files are covered.
  • 471 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-17.5%) to 70.355%

Files with Coverage Reduction New Missed Lines %
compiler_base/error/src/diagnostic/components.rs 6 0.0%
compiler_base/error/src/errors.rs 8 0.0%
compiler_base/session/src/lib.rs 26 58.06%
compiler_base/error/src/diagnostic/mod.rs 27 0.0%
compiler_base/error/src/diagnostic/style.rs 41 0.0%
compiler_base/error/src/diagnostic/diagnostic_message.rs 74 0.0%
compiler_base/error/src/emitter.rs 119 0.0%
compiler_base/error/src/diagnostic/diagnostic_handler.rs 170 0.0%
Totals Coverage Status
Change from base Build 6743237194: -17.5%
Covered Lines: 39320
Relevant Lines: 55888

💛 - Coveralls

@Peefy Peefy added this to the v0.7.0 Release milestone Nov 9, 2023
@Peefy Peefy added api Issues or PRs related to kcl rust native APIs and multi-lang APIs lsp labels Nov 9, 2023
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy marked this pull request as ready for review November 9, 2023 07:02
@Peefy Peefy merged commit e6e98b8 into kcl-lang:main Nov 9, 2023
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api Issues or PRs related to kcl rust native APIs and multi-lang APIs lsp
Projects
No open projects
Status: v0.7.0 Release Done
Development

Successfully merging this pull request may close these issues.

[Feature] support rename/refactor API
3 participants