Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl symbol semantic information injection #851

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

NeverRaR
Copy link
Contributor

@NeverRaR NeverRaR commented Nov 7, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #850

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

feat: impl symbol semantic information injection

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: never <chenxiangfei.cxf@antgroup.com>
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 6779587348

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.82%

Totals Coverage Status
Change from base Build 6779045512: 0.0%
Covered Lines: 2300
Relevant Lines: 2619

💛 - Coveralls

@Peefy Peefy added the semantic Issues or PRs related to kcl semantic and checker label Nov 7, 2023
@Peefy Peefy added this to the v0.7.0 Release milestone Nov 7, 2023
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 6779612584

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.82%

Totals Coverage Status
Change from base Build 6779045512: 0.0%
Covered Lines: 2300
Relevant Lines: 2619

💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Nov 7, 2023

Pull Request Test Coverage Report for Build 6779616187

  • 54 of 116 (46.55%) changed or added relevant lines in 2 files are covered.
  • 471 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-17.5%) to 70.308%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/sema/src/core/symbol.rs 7 15 46.67%
kclvm/sema/src/advanced_resolver/node.rs 47 101 46.53%
Files with Coverage Reduction New Missed Lines %
compiler_base/error/src/diagnostic/components.rs 6 0.0%
compiler_base/error/src/errors.rs 8 0.0%
compiler_base/session/src/lib.rs 26 58.06%
compiler_base/error/src/diagnostic/mod.rs 27 0.0%
compiler_base/error/src/diagnostic/style.rs 41 0.0%
compiler_base/error/src/diagnostic/diagnostic_message.rs 74 0.0%
compiler_base/error/src/emitter.rs 119 0.0%
compiler_base/error/src/diagnostic/diagnostic_handler.rs 170 0.0%
Totals Coverage Status
Change from base Build 6779045512: -17.5%
Covered Lines: 39361
Relevant Lines: 55984

💛 - Coveralls

@Peefy Peefy merged commit a2cbe20 into kcl-lang:main Nov 7, 2023
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
semantic Issues or PRs related to kcl semantic and checker
Projects
No open projects
Status: v0.7.0 Release Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants