Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove the indention check in block '{}' and '[]' #858

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

zong-zhe
Copy link
Contributor

@zong-zhe zong-zhe commented Nov 9, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Fixed #706

2. What is the scope of this PR (e.g. component or file name):

kclvm_parser

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: zongz <zongzhe1024@163.com>
@zong-zhe zong-zhe requested review from i-zhen and Peefy November 9, 2023 13:58
@Peefy Peefy added the parser Issues or PRs related to kcl parser label Nov 9, 2023
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 6812798127

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.82%

Totals Coverage Status
Change from base Build 6808472210: 0.0%
Covered Lines: 2300
Relevant Lines: 2619

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job! LGTM!

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 6812798135

  • 145 of 166 (87.35%) changed or added relevant lines in 8 files are covered.
  • 471 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-17.5%) to 70.322%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/runner/src/tests.rs 16 17 94.12%
kclvm/parser/src/parser/stmt.rs 40 48 83.33%
kclvm/parser/src/parser/expr.rs 57 69 82.61%
Files with Coverage Reduction New Missed Lines %
compiler_base/error/src/diagnostic/components.rs 6 0.0%
compiler_base/error/src/errors.rs 8 0.0%
compiler_base/session/src/lib.rs 26 58.06%
compiler_base/error/src/diagnostic/mod.rs 27 0.0%
compiler_base/error/src/diagnostic/style.rs 41 0.0%
compiler_base/error/src/diagnostic/diagnostic_message.rs 74 0.0%
compiler_base/error/src/emitter.rs 119 0.0%
compiler_base/error/src/diagnostic/diagnostic_handler.rs 170 0.0%
Totals Coverage Status
Change from base Build 6808472210: -17.5%
Covered Lines: 39818
Relevant Lines: 56622

💛 - Coveralls

@Peefy Peefy merged commit 7973b81 into kcl-lang:main Nov 9, 2023
10 of 11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
parser Issues or PRs related to kcl parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Optimize KCL indentation checking without forcing errors
3 participants