Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add suggestion when package not found #860

Merged
merged 5 commits into from
Nov 10, 2023

Conversation

zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

kclvm_parser/sema

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

When KCL fails to find the package during compilation, it outputs some suggestion messages directing to kpm add and search on AH.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: zongz <zongzhe1024@163.com>
@zong-zhe zong-zhe added enhancement New feature or request error-handling Issues or PRs related to kcl error handling labels Nov 10, 2023
@zong-zhe zong-zhe added this to the v0.7.0 Release milestone Nov 10, 2023
@zong-zhe zong-zhe self-assigned this Nov 10, 2023
Signed-off-by: zongz <zongzhe1024@163.com>
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

coveralls commented Nov 10, 2023

Pull Request Test Coverage Report for Build 6822812505

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 97 of 112 (86.61%) changed or added relevant lines in 10 files are covered.
  • 471 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-17.5%) to 70.355%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/error/src/diagnostic.rs 0 1 0.0%
kclvm/parser/src/tests.rs 24 25 96.0%
kclvm/tools/src/LSP/src/quick_fix.rs 0 1 0.0%
kclvm/tools/src/LSP/src/to_lsp.rs 0 2 0.0%
kclvm/error/src/lib.rs 18 28 64.29%
Files with Coverage Reduction New Missed Lines %
compiler_base/error/src/diagnostic/components.rs 6 0.0%
compiler_base/error/src/errors.rs 8 0.0%
compiler_base/session/src/lib.rs 26 58.06%
compiler_base/error/src/diagnostic/mod.rs 27 0.0%
compiler_base/error/src/diagnostic/style.rs 41 0.0%
compiler_base/error/src/diagnostic/diagnostic_message.rs 74 0.0%
compiler_base/error/src/emitter.rs 119 0.0%
compiler_base/error/src/diagnostic/diagnostic_handler.rs 170 0.0%
Totals Coverage Status
Change from base Build 6820627136: -17.5%
Covered Lines: 39913
Relevant Lines: 56731

💛 - Coveralls

Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
@Peefy Peefy merged commit cb4c687 into kcl-lang:main Nov 10, 2023
10 of 11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request error-handling Issues or PRs related to kcl error handling
Projects
No open projects
Status: v0.7.0 Release Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants