Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement rename api with new sema model #890

Merged
merged 4 commits into from Nov 17, 2023

Conversation

amyXia1994
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #880

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

feat: implement rename api with new sema model

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@Peefy Peefy added the lsp label Nov 16, 2023
@Peefy Peefy added this to the v0.7.0 Release milestone Nov 16, 2023
@coveralls
Copy link
Collaborator

coveralls commented Nov 16, 2023

Pull Request Test Coverage Report for Build 6901289674

  • 257 of 286 (89.86%) changed or added relevant lines in 5 files are covered.
  • 471 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-15.9%) to 72.006%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/ast/src/ast.rs 0 1 0.0%
kclvm/query/src/selector.rs 13 14 92.86%
kclvm/tools/src/LSP/src/util.rs 14 16 87.5%
kclvm/query/src/util.rs 0 6 0.0%
kclvm/tools/src/LSP/src/rename.rs 230 249 92.37%
Files with Coverage Reduction New Missed Lines %
compiler_base/error/src/diagnostic/components.rs 6 0.0%
compiler_base/error/src/errors.rs 8 0.0%
compiler_base/session/src/lib.rs 26 58.06%
compiler_base/error/src/diagnostic/mod.rs 27 0.0%
compiler_base/error/src/diagnostic/style.rs 41 0.0%
compiler_base/error/src/diagnostic/diagnostic_message.rs 74 0.0%
compiler_base/error/src/emitter.rs 119 0.0%
compiler_base/error/src/diagnostic/diagnostic_handler.rs 170 0.0%
Totals Coverage Status
Change from base Build 6890713167: -15.9%
Covered Lines: 41498
Relevant Lines: 57631

💛 - Coveralls

Signed-off-by: xiarui.xr <xiarui1994@gmail.com>
kclvm/tools/src/LSP/src/lib.rs Outdated Show resolved Hide resolved
kclvm/tools/src/LSP/src/rename.rs Outdated Show resolved Hide resolved
kclvm/tools/src/LSP/src/rename.rs Outdated Show resolved Hide resolved
kclvm/tools/src/LSP/src/rename.rs Outdated Show resolved Hide resolved
kclvm/tools/src/LSP/src/rename.rs Outdated Show resolved Hide resolved
Signed-off-by: xiarui.xr <xiarui1994@gmail.com>
@Peefy Peefy marked this pull request as ready for review November 17, 2023 02:18
kclvm/tools/src/LSP/src/rename.rs Outdated Show resolved Hide resolved
kclvm/tools/src/LSP/src/rename.rs Outdated Show resolved Hide resolved
Signed-off-by: xiarui.xr <xiarui1994@gmail.com>
Signed-off-by: xiarui.xr <xiarui1994@gmail.com>
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 5d3aec9 into kcl-lang:main Nov 17, 2023
9 of 11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2023
@amyXia1994 amyXia1994 deleted the feat/rename-api-impl branch November 17, 2023 09:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants