Issues with kcl modules about the package re-downloading and local package deps

[dennybaa]

Hello there, again thank you very much for a beautiful project.

I'm just filing an issue to keep track of it, though totally not crucial:

1. Seems that the dependencies can be fetched twice.

kcl mod update
adding 'file-manifests' with version '0.1.0'
downloading 'some-org/iaas-kcl-modules/file-manifests:0.1.0' from 'ghcr.io/some-org/iaas-kcl-modules/file-manifests:0.1.0'
downloading 'some-org/iaas-kcl-modules/file-manifests:0.1.0' from 'ghcr.io/some-org/iaas-kcl-modules/file-manifests:0.1.0'

2. Modules with local dependencies do not work.

Let's admit we have a remote module with the mod file (if I'm not wrong with the actual syntax) as bellow:

[package]
name = "file-manifets"
edition = "v0.8.0"
version = "0.1.0"

[dependencies]
k8s = { oci = "oci://ghcr.io/kcl-lang/k8s", tag = "1.28" }
names = { path = "../names" }

The above package after published is broken, since kcl mod later on tries to resolve names and this doesn't work... Something should be decided regarding this, like would it or not make sense to vendor local dependencies together with the package.

[Peefy]

Thanks for the feedback.

Related Issues:

• Enhancement: kpm needs to add a cache to the downloaded package. #134
• Feat: request and check metadata before downloading the kpm dependencies #301
• [Enhancement] Prohibit packaging and uploading when there are local dependencies in the kcl module #322

cc @zong-zhe

[dennybaa]

Hello there @Peefy @zong-zhe , another issue which might be approached by the above enchancments:

1. kcl -dY kcl.yaml rules/main.k as expected
2. cd ../; kcl -dY main/kcl.yaml main/rules/main.k. Evidently tries to duplicate path...

   Error: Cannot find the kcl file, please check the file path /.../main/main/rules/main.k
   

3. cd ../; kcl -dY main/kcl.yaml rules/main.k. Already fails to resolve modules ....

[Peefy]

1. Closed by feat: prohibit packaging and uploading when there are local dependencies #327 feat: remove keep AcquireDepSum() only in the downloading from OCI #330 fix: fix oci sum missing #331 fix: rm fetch metadata during loading kcl.mod #332
2. Closed by feat: prohibit packaging and uploading when there are local dependencies #327
3. Closed by refactor: strict setting files config running kcl-go#314